Add install script for all clients #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it should be renamed to something like |
|
related: #491 |
vtomole
previously requested changes
Mar 26, 2024
richrines1
reviewed
Mar 26, 2024
install-dev.sh
Outdated
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env sh | |||
| cd $(dirname $0) | |||
| pip install -e $(ls ./*/pyproject.toml | sed 's/\/pyproject.toml/\[dev\]/') | |||
There was a problem hiding this comment.
two notes:
- the
-eflag has to be passed before each package you want to be editable - checks-superstaq doesn't have a [dev] option
i think it would be better to just hard-code all the client names to avoid any ambiguity, e.g.:
Suggested change
| pip install -e $(ls ./*/pyproject.toml | sed 's/\/pyproject.toml/\[dev\]/') | |
| pip install -e ./checks-superstaq -e ./general-superstaq[dev] -e ./qiskit-superstaq[dev] -e ./cirq-superstaq[dev] -e ./superstaq-benchmarks[dev] |
There was a problem hiding this comment.
This gives me an error:
$ ./dev_tools/install.sh
cd ./dev_tools/../
ERROR: ./superstaq-benchmarks[dev] is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with bzr+http, bzr+https, bzr+ssh, bzr+sftp, bzr+ftp, bzr+lp, bzr+file, git+http, git+https, git+ssh, git+git, git+file, hg+file, hg+http, hg+https, hg+ssh, hg+static-http, svn+ssh, svn+http, svn+https, svn+svn, svn+file).
There was a problem hiding this comment.
I think it should go away with ./superstaq-benchmarks[dev] -> ./supermarq-benchmarks[dev]
There was a problem hiding this comment.
Oh right haha. Works now.
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
richrines1
reviewed
Mar 26, 2024
dev_tools/install.sh
Outdated
Comment on lines
2
to
3
| echo cd $(dirname $0)/../ | ||
| pip install -e ./checks-superstaq -e ./general-superstaq[dev] -e ./qiskit-superstaq[dev] -e ./cirq-superstaq[dev] -e ./supermarq-benchmarks[dev] |
There was a problem hiding this comment.
Suggested change
| echo cd $(dirname $0)/../ | |
| pip install -e ./checks-superstaq -e ./general-superstaq[dev] -e ./qiskit-superstaq[dev] -e ./cirq-superstaq[dev] -e ./supermarq-benchmarks[dev] | |
| cd $(dirname $0)/.. | |
| pip install -e ./checks-superstaq -e ./general-superstaq[dev] -e ./qiskit-superstaq[dev] -e ./cirq-superstaq[dev] -e ./supermarq-benchmarks[dev] |
or
Suggested change
| echo cd $(dirname $0)/../ | |
| pip install -e ./checks-superstaq -e ./general-superstaq[dev] -e ./qiskit-superstaq[dev] -e ./cirq-superstaq[dev] -e ./supermarq-benchmarks[dev] | |
| cd $(dirname $0) | |
| pip install -e ../checks-superstaq -e ../general-superstaq[dev] -e ../qiskit-superstaq[dev] -e ../cirq-superstaq[dev] -e ../supermarq-benchmarks[dev] |
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets me (or anyone else) just run
./install.shrather than manually runningpip install -e '.[dev]'in each of the client projects.