Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix hardcoding in validate_target() #960

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

bharat-thotakura
Copy link
Contributor

Addresses part of #958 by unblocking the backends() endpoint of qiskit-superstaq.

Will also allow calls to the compile endpoint with iqm_* backends (though further optimization may be needed).

Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! though we should think about removing the hard-coded vendors entirely..

@bharat-thotakura
Copy link
Contributor Author

^ I can go ahead & remove the following:

# Check valid prefix
if prefix not in vendor_prefixes:
raise ValueError(
f"{target!r} does not have a valid target prefix. Valid prefixes are: "
f"{vendor_prefixes}."
)

I just wasn't sure what the original motivation was to have that check or what other condition we should replace it with, if any

@richrines1
Copy link
Contributor

i think it's fine to remove. i believe the motivation was just to catch easy errors before they hit the server, but now that our list of supported devices is somewhat dynamic this doesn't make much sense

@bharat-thotakura bharat-thotakura changed the title Support iqm backend in validate_target() Remove prefix hardcoding in validate_target() Jun 7, 2024
@bharat-thotakura bharat-thotakura merged commit 82d70a4 into main Jun 7, 2024
19 checks passed
@bharat-thotakura bharat-thotakura deleted the add-iqm-support branch June 7, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants