Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edge authentication #91

Merged
merged 4 commits into from
Jul 11, 2024
Merged

feat: Edge authentication #91

merged 4 commits into from
Jul 11, 2024

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jul 10, 2024

Closes #88

Proposed Changes

Briefly describe your proposed changes:

Refactored #88, based on my comments there:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (1c6ab94) to head (0cb1038).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   84.48%   84.62%   +0.14%     
==========================================
  Files          14       14              
  Lines        1096     1106      +10     
==========================================
+ Hits          926      936      +10     
  Misses        140      140              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review July 10, 2024 10:15
@alespour alespour mentioned this pull request Jul 10, 2024
6 tasks
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 👍

LGTM 🚀

@alespour alespour merged commit 7d9a001 into main Jul 11, 2024
17 checks passed
@alespour alespour deleted the fix/edge-authentication branch July 11, 2024 07:11
alespour added a commit that referenced this pull request Jul 11, 2024
@alespour alespour mentioned this pull request Jul 11, 2024
3 tasks
@bednar bednar added this to the 0.9.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants