Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Firefox 51+ (broken ability to toggle private state of already opened tabs) #237

Closed
dehghani-mehdi opened this issue Nov 17, 2016 · 18 comments

Comments

Projects
None yet
6 participants
@dehghani-mehdi
Copy link

commented Nov 17, 2016

Hi,

Please add support for Firefox v52.x

Thank you !

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2016

See
https://bugzilla.mozilla.org/show_bug.cgi?id=1315233#c24
https://bugzilla.mozilla.org/show_bug.cgi?id=1315233#c27
https://bugzilla.mozilla.org/show_bug.cgi?id=1318388

This is forced compatibility from AMO side...
I need feedback from Firefox developers to do something with this.

Also extensions.checkCompatibility.52.0 = false (for Firefox 52) in about:config should allow to install/use anyway.

@Dimas-sc

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2016

Hope they will answer soon, now we don't have Private Tab on Firefox 51 beta :( I voted for the bug

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2016

Oh,

(https://bugzilla.mozilla.org/show_bug.cgi?id=1315233#c33)

Also... The most important question.
How correctly implement private tabs?

See above, but I'm not sure there's really any "correct" way without a lot of
platform changes, at this point. But we can continue this conversation in the
other bug.

О_О

@Dimas-sc

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2016

Do you have a plan now that bug is "fixed"? :(

@Infocatcher Infocatcher changed the title Please add support for v52.x Compatibility with Firefox 51+ Dec 26, 2016

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Dec 26, 2016

Do you have a plan now that bug is "fixed"? :(

See https://bugzilla.mozilla.org/show_bug.cgi?id=1318388#c35

So, I don't see any way to fix this from my side. :(

May me is needed more feedback from users: more bugs on https://bugzilla.mozilla.org/ and more comments...

Infocatcher added a commit that referenced this issue Dec 27, 2016

@rctgamer3

This comment has been minimized.

Copy link

commented Dec 29, 2016

@Infocatcher Are you planning on submitting the workaround / a version that works on 52 and up to AMO any time soon, either a a full update or as a quick beta version?

Infocatcher added a commit that referenced this issue Jan 10, 2017

Don't modify tabs at "SSTabRestoring" in capturing phase
Weird things may happens sometimes (like empty tab with correct favicon)
(#237)

Infocatcher added a commit that referenced this issue Jan 10, 2017

Try handle duplicated tab before loading and initialization
See SessionStoreInternal.restoreTab() -> sendAsyncMessage("SessionStore:restoreHistory", …)
(#237)

Infocatcher added a commit that referenced this issue Jan 12, 2017

Simplify way to mark duplicated tab as private
Also now we can't use "SSTabRestoring", will dispatched too late: #239
(#237)
@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Jan 14, 2017

Test version: private_tab-0.2.1pre-fx-sm.xpi (source code).

Now will be opened duplicated tab to toggle private state of already opened tab, so extensions.privateTab.toggleTabPrivateAutoReload and extensions.privateTab.toggleTabPrivateAutoReload.stopLoading haven't effect.
Also all private data may be cleared like after closing of all private tabs and windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1329912 (so, should be opened at least one remote private tab to leave data).

@harl

This comment has been minimized.

Copy link

commented Jan 14, 2017

Looks good so far. The icon is back (I had to re-add it to the bar) and it simply opens a "New Tab" tab in private browsing mode, ready to be used even with TMP's feature to always open a new tab from the address bar (because it re-uses the current tab if it's a "New Tab"). Will check back if I find anything unusual.

@Dimas-sc

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2017

Thx!! Waiting for it :D

@Rikk

This comment has been minimized.

Copy link

commented Jan 19, 2017

The toggle works intermittently in new FF 51, ie. after some tries (ctrl+alt+t) it become enabled and after some tries it is disabled.

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2017

Also corrected: http://forums.mozillazine.org/viewtopic.php?p=14728853#p14728853
x Correctly update window title and style, if toggled private state of selected non-remote tab (restored non-remote private tab) in Firefox 51+ (#237, #239).

For now I don't like to touch AMO to not break review queue...

Test version: private_tab-0.2.1.1pre-fx-sm.xpi (source code)

And now non-AMO versions will update automatically to pre-releases (since now it's not clear, how to use them on non-test browser versions).

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2017

The toggle works intermittently in new FF 51, ie. after some tries (ctrl+alt+t) it become enabled and after some tries it is disabled.

Only hotkey or "Private Tab" checkbox from tab context menu too? And what exactly happens: nothing instead of toggling or something else?

@Rikk

This comment has been minimized.

Copy link

commented Jan 20, 2017

Both. It is like the tab get cloned and old tab is closed, but the new cloned tab more often doesn't become private.
In following video, each reload of the tab means ctrl+alt+t hotkey was pressed, note that sometimes it even fails to load the page and opens a blank page:
ScreenCapture_20-01-2017 1.wmv.gz

In this other recording, it is interesting to note that when I toggle private state of the tab before I open it first, it seems to work much better:
ScreenCapture_20-01-2017 2.wmv.gz

(Sorry about the Gzip, I tried to upload as Zip, but GitHub didn't accept, but this shouldn't be a problem I hope)

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Jan 21, 2017

note that sometimes it even fails to load the page and opens a blank page

Will be better with 95a44ce

Test version: private_tab-0.2.1.1pre2-fx-sm.xpi (source code).

For example, I can't properly move a selection of one normal tab and one private tab to a new window -- the normal tab is moved and the other becomes a weird blank "New Tab" with site's favicon but broken and impossible to close. It once made the browser into a loop and freeze using high-cpu.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1279094
And even still "unconfirmed"...

@Rikk

This comment has been minimized.

Copy link

commented Jan 21, 2017

Blank page fix seems not effective yet 😟
If you toggle very fast (tip: keep hotkey pressed), still happens 100% of the time.

About moving tabs, I don't have e10s thing enabled, and it was working properly in 50.1 until I updated to 51, then I'm not sure it is the same case of this bugzilla...
('Unconfirmed for years' is the result of bug reports made by unimportant persons like me and this guy... I never had luck reporting bugs for them)

Infocatcher added a commit that referenced this issue Jan 21, 2017

Correctly toggle private state of pending tabs
(docShell isn't initialized yet, so we can modify .usePrivateBrowsing)
(#237)

Infocatcher added a commit that referenced this issue Jan 23, 2017

Toggle private state of not initialized tab after delay
(to not break tab data by duplication process)
(#237)
@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Jan 23, 2017

Blank page fix seems not effective yet 😟
If you toggle very fast (tip: keep hotkey pressed), still happens 100% of the time.

Will be better with following corrections: a5ef6b2, 549de7b
Now command to toggle private state will do nothing, if previous duplication is still in progress and will wait up to 300 ms, if looks like tab isn't initialized yet.

Test version: private_tab-0.2.1.2pre2-fx-sm.xpi (source code)

Infocatcher added a commit that referenced this issue Jan 27, 2017

Increase delay to check real tab state after "TabSelect":
tab duplication may be slow ("SSTabRestoring" may happens after our previous delay)
(related to #237)

Infocatcher added a commit that referenced this issue Jan 27, 2017

Infocatcher added a commit that referenced this issue Jan 27, 2017

Infocatcher added a commit that referenced this issue Jan 27, 2017

Tweak changelog:
* toggle private state of pinned tabs (#237)
* toggle private state with disabled multi-process mode (#237, #241)

@Infocatcher Infocatcher changed the title Compatibility with Firefox 51+ Compatibility with Firefox 51+ (broken ability to toggle private state of already opened tabs) Jan 31, 2017

Infocatcher added a commit that referenced this issue Feb 20, 2017

Update changelog:
* toggle using duplication: try restore URL bar (#237)
* fixed private protocol in Firefox 37-43 (#247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.