Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging Private Tabs to non-private window malfunctions #242

Open
xpev opened this issue Jan 31, 2017 · 2 comments

Comments

@xpev
Copy link

commented Jan 31, 2017

If you create a private Tab and use Drag & Drop to move so it would create a new Firefox Window a new window gets created but the Tab itself becomes useless. The URL is gone, you cannot close the tab and you cannot load a new URL. The new window itself is fine and new tabs (even private) can be created.

If you Drag & Drop tabs from a private window it does work normally.

@xpev xpev changed the title Dragging Private Tabs to make new video malfunctions Dragging Private Tabs to non-private window malfunctions Feb 1, 2017
@xpev

This comment has been minimized.

Copy link
Author

commented Feb 1, 2017

I played a bit with that and found the following: If you move the private tab to a non-private windows the explained error happens. White window, tab unusable and unclosable. I even tried a fresh Firefox Profile, it still happens.
Before dragging: window1
Afterwards: window2

If you drag the private tab out of a non-private window into a private one it works as intended, the other way around also produces the error.

@Infocatcher Infocatcher added the bug label Feb 4, 2017
@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Feb 4, 2017

Also see #237 (comment) and https://bugzilla.mozilla.org/show_bug.cgi?id=1279094 (for e10s, but looks like something related).

And for now works better with enabled e10s.
Also broken even without Private Tab, this caused only by following thing:

gBrowser.selectedBrowser.docShell
	.QueryInterface(Components.interfaces.nsILoadContext)
	.usePrivateBrowsing = true;

(that used inside Private Tab to toggle built-in private mode)

Infocatcher added a commit that referenced this issue May 29, 2017
Looks like works trick with docShell.inheritPrivateBrowsingId = false (for disabled e10s)
Thanks to Dumby: https://forum.mozilla-russia.org/viewtopic.php?pid=737516#p737516
(#242)
Infocatcher added a commit that referenced this issue Jul 16, 2017
* trick to drag private tab to another window (#242)
* added Dutch (nl) locale (#268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.