Skip to content

Commit

Permalink
Remove unused COLLAPSABLE_FOLDER_EXISTENCE_HAS_CHANGED payload
Browse files Browse the repository at this point in the history
  • Loading branch information
KevinBoulongne committed Jul 4, 2024
1 parent 9c9dbcb commit 8820798
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 36 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -215,21 +215,13 @@ class MenuDrawerAdapter @Inject constructor() : ListAdapter<Any, MenuDrawerViewH
}

override fun onBindViewHolder(holder: MenuDrawerViewHolder, position: Int, payloads: MutableList<Any>) {
when (payloads.firstOrNull()) {
NotifyType.MAILBOXES_HEADER_CLICKED -> MailboxesHeaderItem.displayWithPayload(
if (payloads.firstOrNull() == NotifyType.MAILBOXES_HEADER_CLICKED) {
MailboxesHeaderItem.displayWithPayload(
item = items[position],
binding = holder.binding,
)
NotifyType.COLLAPSABLE_FOLDER_EXISTENCE_HAS_CHANGED -> FolderItem.displayWithPayload(
item = items[position],
binding = holder.binding,
currentFolderId = currentFolderId,
hasCollapsableDefaultFolder = hasCollapsableDefaultFolder,
hasCollapsableCustomFolder = hasCollapsableCustomFolder,
onFolderClicked = onFolderClicked,
onCollapseChildrenClicked = onCollapseChildrenClicked,
)
else -> super.onBindViewHolder(holder, position, payloads)
} else {
super.onBindViewHolder(holder, position, payloads)
}
}

Expand Down Expand Up @@ -290,7 +282,6 @@ class MenuDrawerAdapter @Inject constructor() : ListAdapter<Any, MenuDrawerViewH

private enum class NotifyType {
MAILBOXES_HEADER_CLICKED,
COLLAPSABLE_FOLDER_EXISTENCE_HAS_CHANGED, // TODO: This seems to never be notified ??
}

private class FolderDiffCallback : DiffUtil.ItemCallback<Any>() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,29 +63,6 @@ object FolderItem {
)
}

fun displayWithPayload(
item: Any,
binding: ViewBinding,
currentFolderId: String?,
hasCollapsableDefaultFolder: Boolean,
hasCollapsableCustomFolder: Boolean,
onFolderClicked: (folderId: String) -> Unit,
onCollapseChildrenClicked: (folderId: String, shouldCollapse: Boolean) -> Unit,
) {
item as Folder
binding as ItemMenuDrawerFolderBinding

Log.d("Bind", "Bind Custom folders because of collapse change = ${item.name}")
binding.displayFolder(
item,
currentFolderId,
hasCollapsableDefaultFolder,
hasCollapsableCustomFolder,
onFolderClicked,
onCollapseChildrenClicked,
)
}

private fun ItemMenuDrawerFolderBinding.displayFolder(
folder: Folder,
currentFolderId: String?,
Expand Down

0 comments on commit 8820798

Please sign in to comment.