Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back missing animations when removing Attachments #1834

Merged
merged 3 commits into from
May 1, 2024

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Apr 30, 2024

We were notifying twice the Adapter when removing an Attachment, so the animation was cancelled.

@KevinBoulongne KevinBoulongne added the bug Something isn't working label Apr 30, 2024
@KevinBoulongne KevinBoulongne requested a review from a team as a code owner April 30, 2024 08:44
@github-actions github-actions bot added the dependent This MR depends on another PR label Apr 30, 2024
@KevinBoulongne KevinBoulongne changed the base branch from too-much-draft-saving to draft-revamp May 1, 2024 08:21
@github-actions github-actions bot removed the dependent This MR depends on another PR label May 1, 2024
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit 627db89 into draft-revamp May 1, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the attachments-animations branch May 1, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants