Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SignatureAdapter memory leak #1836

Closed
wants to merge 2 commits into from
Closed

Remove SignatureAdapter memory leak #1836

wants to merge 2 commits into from

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Apr 30, 2024 •
edited
Loading

Depends on #1834

Remove strong reference about SignatureAdapter in NewMessageFragment.

@KevinBoulongne KevinBoulongne added the bug Something isn't working label Apr 30, 2024
@KevinBoulongne KevinBoulongne requested a review from a team as a code owner April 30, 2024 14:37
@github-actions github-actions bot added the dependent This MR depends on another PR label Apr 30, 2024
@KevinBoulongne KevinBoulongne requested a review from LunarX May 1, 2024 08:26
Base automatically changed from attachments-animations to draft-revamp May 1, 2024 08:29
@github-actions github-actions bot removed the dependent This MR depends on another PR label May 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

This PR/issue depends on:

@KevinBoulongne KevinBoulongne mentioned this pull request May 1, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

LunarX
LunarX reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure the adapter for a list actually leaks in the first place? Because maybe only recyclerview's ones do. Maybe list adapters don't have a strong reference to their ListPopupWindow

@KevinBoulongne KevinBoulongne marked this pull request as draft May 2, 2024 06:50
auto-merge was automatically disabled May 2, 2024 06:50

Pull request was converted to draft

@KevinBoulongne KevinBoulongne deleted the memory-leak branch May 2, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX requested changes

@FabianDevel FabianDevel FabianDevel approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KevinBoulongne @LunarX @FabianDevel