Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save Draft in Activity onStop instead of Fragment one #1838

Closed
wants to merge 1 commit into from
Closed

Save Draft in Activity onStop instead of Fragment one #1838

wants to merge 1 commit into from

Conversation

KevinBoulongne
Copy link
Contributor

Depends on #1832

Move the Draft saving from the Fragment's onStop to the Activity's onStop instead.
It will lessen the Toast spam of "Saving draft".

@KevinBoulongne KevinBoulongne added the enhancement Improve or expand upon an existing feature label May 1, 2024
@KevinBoulongne KevinBoulongne requested a review from a team as a code owner May 1, 2024 12:09
@github-actions github-actions bot added the dependent This MR depends on another PR label May 1, 2024
Base automatically changed from too-much-draft-saving to draft-revamp May 1, 2024 12:41
@github-actions github-actions bot removed the dependent This MR depends on another PR label May 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

This PR/issue depends on:

@KevinBoulongne KevinBoulongne changed the title Save Draft when Activity onStop instead of Fragment one Save Draft in Activity onStop instead of Fragment one May 1, 2024
@KevinBoulongne KevinBoulongne force-pushed the saveDraft-in-Activity branch 2 times, most recently from 969f6b3 to 6bfb8c4 Compare May 2, 2024 07:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne requested a review from LunarX May 2, 2024 07:57
@KevinBoulongne KevinBoulongne deleted the saveDraft-in-Activity branch May 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX Awaiting requested review from LunarX

Assignees

@KevinBoulongne KevinBoulongne

Labels
enhancement Improve or expand upon an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KevinBoulongne @LunarX