Only save Draft when adding Attachment #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
added
the
optimization
KevinBoulongne
force-pushed
the
draft-revamp
branch
from
feb9794
to
58d270f
Compare
KevinBoulongne
force-pushed
the
too-much-draft-saving
branch
from
34f4e48
to
ba4a4c5
Compare
KevinBoulongne
force-pushed
the
draft-revamp
branch
from
58d270f
to
b6a6d35
Compare
KevinBoulongne
force-pushed
the
too-much-draft-saving
branch
from
ba4a4c5
to
62ac7e8
Compare
FabianDevel
requested changes
Apr 30, 2024
There was a problem hiding this comment.
This display a toast (should be a snackbar I think as we stay in the app) when coming b ack to the activity after saving an attachment
This is annoying as we are already displaying a toast when quitting the activity to open the picker
We probably shouldn't display anything when coming back to the activity
EDIT: it will be done, but in another PR
auto-merge was automatically disabled
May 1, 2024 08:21
Pull request was converted to draft
KevinBoulongne
force-pushed
the
too-much-draft-saving
branch
2 times, most recently
from
ab72feb
to
0b1c0bc
Compare
KevinBoulongne
force-pushed
the
memory-leak
branch
from
998a574
to
8f5b285
Compare
KevinBoulongne
force-pushed
the
too-much-draft-saving
branch
from
0b1c0bc
to
a00c96b
Compare
FabianDevel
approved these changes
May 1, 2024
KevinBoulongne
force-pushed
the
too-much-draft-saving
branch
from
6740f33
to
5be7da0
Compare
KevinBoulongne
force-pushed
the
too-much-draft-saving
branch
from
9d40271
to
5be7da0
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were saving Draft everytime we add or remove an Attachment, it's too much.
Now, we only save Draft when adding an Attachment.
Also, if we add a lot of Attachments at the same time (via the FilePicker), and we delete them all while it's still saving, the DraftsActionsWorker will fail because it's won't find the files on the phone disk.
Now, it will just ignore these failures so the Draft can be saved.