Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested #3: Some MoveFragment fixes #1901

Closed
wants to merge 25 commits into from
Closed

Nested #3: Some MoveFragment fixes #1901

wants to merge 25 commits into from

Conversation

KevinBoulongne
Copy link
Contributor

Depends on #1897

  • Draft folder was displayed in the Move fragment list. It shouldn't, we can't move an email to the Draft folder.
  • The sub-folders were still indented when doing a search. We don't want to do that.

@KevinBoulongne KevinBoulongne added the bug Something isn't working label Jun 7, 2024
@KevinBoulongne KevinBoulongne requested a review from a team June 7, 2024 11:46
@github-actions github-actions bot added the dependent This MR depends on another PR label Jun 7, 2024
@KevinBoulongne KevinBoulongne mentioned this pull request Jun 7, 2024
Closed
@KevinBoulongne KevinBoulongne changed the title MoveFragment fixes Some MoveFragment fixes Jun 7, 2024
@KevinBoulongne KevinBoulongne marked this pull request as ready for review June 7, 2024 12:09
@KevinBoulongne KevinBoulongne changed the title Some MoveFragment fixes Nested #3: Some MoveFragment fixes Jun 10, 2024
@KevinBoulongne KevinBoulongne mentioned this pull request Jun 11, 2024
Merged
@KevinBoulongne KevinBoulongne force-pushed the move-fixes branch 2 times, most recently from 7841653 to e874b2e Compare June 11, 2024 11:58
@KevinBoulongne
Rename items into folders in FolderAdapter
0fa5cb3
@KevinBoulongne
Move tag attribution to the correct spot
d577a2c
@KevinBoulongne
Remove duplicated FolderAdapter
9fcb4be
@KevinBoulongne
Apply suggestions from code review
a20976b
@KevinBoulongne
Remove now useless getFolders…() functions
0da6753
@KevinBoulongne
Rename menu package into menuDrawer
8ad7ef2
@KevinBoulongne
Move some files to new move package
83832cd
@KevinBoulongne
Rename layouts to match MenuDrawer layouts name format
a74a146
@KevinBoulongne
Clean code
662e573
@KevinBoulongne
Don't display Draft folder in MoveFragment list
e0232e3
@KevinBoulongne
Don't display subFolders indent in MoveFragment when searching for a …
e0dbca3 
…folder
@KevinBoulongne
Add missing default parameter value in setFolders
3de9de6
@KevinBoulongne
Add TODO
e90abb0
@KevinBoulongne
Order code
056f062
@KevinBoulongne
Simplify setSearchBarUi() code
545eb8f
@KevinBoulongne
Remove side effect of currentFolderId being set in a hidden way
1640b70
@KevinBoulongne
Rename setSearchBarUi() into setupSearchBar()
7736ce0
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from move-files to nested-scroll-views June 13, 2024 10:40
@github-actions github-actions bot removed the dependent This MR depends on another PR label Jun 13, 2024
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@KevinBoulongne KevinBoulongne deleted the move-fixes branch June 13, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KevinBoulongne KevinBoulongne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBoulongne @tevincent