Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forward and reply icons on threads #1939

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Add forward and reply icons on threads #1939

merged 11 commits into from
Jul 16, 2024

Conversation

TommyDL-Infomaniak
Copy link
Contributor

No description provided.

@TommyDL-Infomaniak TommyDL-Infomaniak requested a review from a team June 26, 2024 06:41
@TommyDL-Infomaniak TommyDL-Infomaniak self-assigned this Jun 26, 2024
@TommyDL-Infomaniak TommyDL-Infomaniak added feature Add a new function or capability to the project quick A pull request consisting of a few lines labels Jun 26, 2024
@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Jun 27, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 27, 2024
LunarX
LunarX requested changes Jun 27, 2024
View reviewed changes
app/src/main/res/drawable/ic_forward_arrow.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/cardview_thread_item.xml Outdated Show resolved Hide resolved
LunarX
LunarX requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do anything for people who already had badly computed isAnswered and isForwarded values inside their Thread objects already stored on realm?

@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Jun 27, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 27, 2024
@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Jun 28, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 28, 2024
@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Jun 28, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 28, 2024
@TommyDL-Infomaniak
Copy link
Contributor Author

We don't do anything for people who already had badly computed isAnswered and isForwarded values inside their Thread objects already stored on realm?

After discussion with the iOS team, it was decided that it is not worth it.

@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Jul 4, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jul 4, 2024
@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Jul 15, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jul 15, 2024
@TommyDL-Infomaniak TommyDL-Infomaniak added the rebase Add this label to rebase the PR label Jul 15, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jul 15, 2024
@KevinBoulongne KevinBoulongne added rebase Add this label to rebase the PR and removed quick A pull request consisting of a few lines labels Jul 16, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jul 16, 2024
@KevinBoulongne KevinBoulongne removed the request for review from FabianDevel July 16, 2024 07:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit 969e149 into master Jul 16, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the ft/forward-and-reply-icons branch July 16, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

@LunarX LunarX LunarX approved these changes

@tevincent tevincent tevincent approved these changes

Assignees

@TommyDL-Infomaniak TommyDL-Infomaniak

Labels
feature Add a new function or capability to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TommyDL-Infomaniak @KevinBoulongne @LunarX @tevincent