Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag BIMI #1946

Merged
merged 15 commits into from
Jul 3, 2024
Merged

Feature flag BIMI #1946

merged 15 commits into from
Jul 3, 2024

Conversation

NicolasBourdin88
Copy link
Contributor

No description provided.

@NicolasBourdin88 NicolasBourdin88 added the feature Add a new function or capability to the project label Jul 1, 2024
@NicolasBourdin88 NicolasBourdin88 requested review from LunarX and a team July 1, 2024 12:55
@NicolasBourdin88 NicolasBourdin88 self-assigned this Jul 1, 2024
@KevinBoulongne KevinBoulongne changed the title Feature flag bimi Feature flag BIMI Jul 2, 2024
LunarX
LunarX requested changes Jul 2, 2024
View reviewed changes
app/src/main/java/com/infomaniak/mail/views/itemViews/AvatarMergedContactData.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/mail/views/AvatarView.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/mail/views/AvatarView.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/mail/views/AvatarView.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/mail/views/AvatarView.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/mail/views/AvatarView.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/mail/utils/SharedUtils.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/mail/utils/SharedUtils.kt Outdated Show resolved Hide resolved
@NicolasBourdin88
Correctly save internal avatar state
ef00ba0 
Avoid missing correspondant when Bimi is deactivated
@NicolasBourdin88 NicolasBourdin88 force-pushed the feature-flag-bimi branch 2 times, most recently from 63b51d9 to 94fcb15 Compare July 2, 2024 08:23
@NicolasBourdin88 @KevinBoulongne
Update app/src/main/java/com/infomaniak/mail/views/AvatarView.kt
b8aedb1 
Co-authored-by: Kevin Boulongne <1788629+KevinBoulongne@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@NicolasBourdin88 NicolasBourdin88 merged commit 5b6daff into master Jul 3, 2024
4 checks passed
@NicolasBourdin88 NicolasBourdin88 deleted the feature-flag-bimi branch July 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

@LunarX LunarX LunarX approved these changes

@tevincent tevincent tevincent approved these changes

@TommyDL-Infomaniak TommyDL-Infomaniak TommyDL-Infomaniak approved these changes

Assignees

@NicolasBourdin88 NicolasBourdin88

Labels
feature Add a new function or capability to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NicolasBourdin88 @KevinBoulongne @LunarX @tevincent @TommyDL-Infomaniak