Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag BIMI #1946

Merged
merged 15 commits into from
Jul 3, 2024
Merged

Feature flag BIMI #1946

merged 15 commits into from
Jul 3, 2024

Commits on Jun 28, 2024

  1. Add bimi in FeatureFlag enum class

    @NicolasBourdin88
    NicolasBourdin88 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    502e9af View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. implement feature flag

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    17a163b View commit details
    Browse the repository at this point in the history

  2. move function after all loading avatar function

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d63b96f View commit details
    Browse the repository at this point in the history

  3. Rename mediator and add comment to better comprehension

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0ca7a40 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. removed unused value and import

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5d92db9 View commit details
    Browse the repository at this point in the history

  2. Correctly save internal avatar state 

    Avoid missing correspondant when Bimi is deactivated
    @NicolasBourdin88
    NicolasBourdin88 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ef00ba0 View commit details
    Browse the repository at this point in the history

  3. Add internal state to define avatar view state

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b31ab46 View commit details
    Browse the repository at this point in the history

  4. Avoid live data to be notify for the same value

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    82b31c9 View commit details
    Browse the repository at this point in the history

  5. Apply suggestion from code review

    @NicolasBourdin88 @KevinBoulongne
    NicolasBourdin88 authored and KevinBoulongne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5055ea7 View commit details
    Browse the repository at this point in the history

  6. Rewrite AvatarView InternalState class

    @KevinBoulongne
    KevinBoulongne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3aa1c22 View commit details
    Browse the repository at this point in the history

  7. Add edit mode

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3396644 View commit details
    Browse the repository at this point in the history

  8. Apply suggestion from code review

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    fefe750 View commit details
    Browse the repository at this point in the history

  9. Better definition of avatarMediatorLiveData

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d3ee2d2 View commit details
    Browse the repository at this point in the history

  10. Update app/src/main/java/com/infomaniak/mail/views/AvatarView.kt 

    Co-authored-by: Kevin Boulongne <1788629+KevinBoulongne@users.noreply.github.com>
    @NicolasBourdin88 @KevinBoulongne
    NicolasBourdin88 and KevinBoulongne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b8aedb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Use LiveData instead of MutableLiveData

    @NicolasBourdin88
    NicolasBourdin88 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ecbc35b View commit details
    Browse the repository at this point in the history