Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modern account switcher #1202

Merged
merged 9 commits into from
Jul 3, 2024
Merged

feat: Modern account switcher #1202

merged 9 commits into from
Jul 3, 2024

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Jun 20, 2024 •
edited
Loading

  • Double tap on the avatar should bring up the next account
  • Long touch should display the account list

Double tap looks like a hack because it is one, as tap events over a tabBar are not something iOS allows you to do easily.
Yet this implementation is relatively safe.

Blocked by for AppNavigable (router class) #1187

double_tap.MP4

@adrien-coye adrien-coye changed the title feat: Detect double tap on profile picture feat: Modern account switcher Jun 28, 2024
adrien-coye
adrien-coye commented Jun 28, 2024
View reviewed changes
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes for future reviewers

kDrive/UI/Controller/MainTabViewController.swift Show resolved Hide resolved
kDrive/UI/View/Menu/MainTabBar.swift Outdated Show resolved Hide resolved
kDrive/UI/View/Menu/MainTabBar.swift Outdated Show resolved Hide resolved
kDrive/UI/View/Menu/MainTabBar.swift Show resolved Hide resolved
kDrive/UI/View/Menu/MainTabBar.swift Show resolved Hide resolved
kDrive/UI/Controller/MainTabViewController.swift Outdated Show resolved Hide resolved
@adrien-coye adrien-coye force-pushed the releaseAPIV3-modernAccountSwitch branch from 86d5aec to a58611a Compare June 28, 2024 13:38
@adrien-coye adrien-coye added this to the APIV3 milestone Jun 28, 2024
@adrien-coye adrien-coye marked this pull request as ready for review July 1, 2024 12:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adrien-coye adrien-coye merged commit 24a06dd into releaseAPIV3 Jul 3, 2024
2 checks passed
@adrien-coye adrien-coye deleted the releaseAPIV3-modernAccountSwitch branch July 3, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrien-coye @valentinperignon