feat: Migration to modern restoration API #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
force-pushed
the
releaseAPIV3-restorationScene
branch
from
50237ab
to
05a26c7
Compare
adrien-coye
commented
May 24, 2024
adrien-coye
commented
May 24, 2024
adrien-coye
commented
May 24, 2024
…-restorationScene-reEnableRestoration
5 tasks
…o SendableProperty
fix: UTRootViewControllerState fix: ITDrive
adrien-coye
commented
Jun 28, 2024
adrien-coye
commented
Jun 28, 2024
kDrive/UI/Controller/Files/FileActionsFloatingPanelViewController+Actions.swift
Show resolved
Hide resolved
adrien-coye
commented
Jun 28, 2024
…e-unittests test: Testing scene restoration metadata
|
PhilippeWeidmann
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Migrating to
UISceneDelegate, as the requirement for this is iOS13.This will be the occasion to split navigation code away from the
AppDelegate.Also checking old restoration code while migrating it.
State restoration no longer has a stand-alone code path, but instead use routing code to replay navigation commands.
Navigation was reworked to make good use of async await.
Global TODOs: