Merge pull request #1145 from Infomaniak/pass-accent-color

perf(ThreadListView): Stop observing AppStorage at cell level
Infomaniak · Nov 28, 2023 · b2f39a5 · b2f39a5
2 parents c76025a + e12afb8
commit b2f39a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Mail/Views/Thread List/ThreadListCell.swift b/Mail/Views/Thread List/ThreadListCell.swift
@@ -38,14 +38,13 @@ struct ThreadListCell: View {
     @EnvironmentObject private var splitViewManager: SplitViewManager
     @EnvironmentObject private var mainViewState: MainViewState
 
-    @AppStorage(UserDefaults.shared.key(.accentColor)) private var accentColor = DefaultPreferences.accentColor
-
     let viewModel: ThreadListViewModel
     @ObservedObject var multipleSelectionViewModel: ThreadListMultipleSelectionViewModel
 
     let thread: Thread
 
     let threadDensity: ThreadDensity
+    let accentColor: AccentColor
 
     let isSelected: Bool
     let isMultiSelected: Bool
@@ -128,6 +127,7 @@ struct ThreadListCell_Previews: PreviewProvider {
             multipleSelectionViewModel: ThreadListMultipleSelectionViewModel(),
             thread: PreviewHelper.sampleThread,
             threadDensity: .large,
+            accentColor: .pink,
             isSelected: false,
             isMultiSelected: false,
             flushAlert: .constant(nil)

diff --git a/Mail/Views/Thread List/ThreadListView.swift b/Mail/Views/Thread List/ThreadListView.swift
@@ -102,6 +102,7 @@ struct ThreadListView: View {
                                                multipleSelectionViewModel: multipleSelectionViewModel,
                                                thread: thread,
                                                threadDensity: threadDensity,
+                                               accentColor: accentColor,
                                                isSelected: viewModel.selectedThread?.uid == thread.uid,
                                                isMultiSelected: multipleSelectionViewModel.selectedItems.contains(thread),
                                                flushAlert: $flushAlert)