Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Provide default date when decoding Thread #1177

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: Provide default date when decoding Thread #1177

merged 1 commit into from
Dec 14, 2023

Conversation

PhilippeWeidmann
Copy link
Member

The threads returned by search route can sometimes return a nil date.

@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner December 14, 2023 09:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

adrien-coye
adrien-coye approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@valentinperignon valentinperignon merged commit 3e71fdf into master Dec 14, 2023
7 checks passed
@valentinperignon valentinperignon deleted the fix-thread-decoding branch December 14, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees

@PhilippeWeidmann PhilippeWeidmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilippeWeidmann @adrien-coye @valentinperignon