Large complex mails are slow to display #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
force-pushed
the
largeComplexMailSlowToDisplay
branch
from
4daf2ad
to
c6b21c2
Compare
adrien-coye
commented
May 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Ambrdctr
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation
Preprocessing of the mail is blowing up with large ones.
The preprocessing we do with "swift soup" is blowing up not in a manner I can quickly optimize.
Proposed solution
Therefore I used an heuristic to disable preprocessing of emails larger than 5meg.
Works like a charm, email is still displayed resonably well, and some other mail clients use this trick.
“Possibly the most common error of a smart engineer is to optimise a thing that should not exist” - Musk