Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SwiftUI app #838

Merged
merged 25 commits into from
Jul 10, 2023
Merged

feat: SwiftUI app #838

merged 25 commits into from
Jul 10, 2023

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann
feat(SwiftUI App Lifecycle): Basic conversion
3a9ba3e
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): Account Switch / Theme / Accent / AppDel…
cb02846 
…egate
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): RootView switching
dca5b7f
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): Account switching
8e60909
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): ThreadListManagerView - Ensure ViewModel…
b7b455b 
… recreation
@PhilippeWeidmann
Merge branch 'master' into swiftui-app
e9e8016 
# Conflicts:
#	Mail/AppDelegate.swift
#	Mail/Utils/NavigationStore.swift
#	Mail/Views/SplitView.swift
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): MenuDrawerView - Ensure FolderListView u…
6a4dca2 
…pdate
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): Remove @Environment(\.window)
a2af080
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): NavigationDrawer stop using @Environment(…
48bbde0 
…\.window)
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): Handle mailto urls
cd00a9c
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): NoMailboxView stop using SceneDelegate
a8d7b72
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): Remove SceneDelegate
abf4794
@PhilippeWeidmann
feat(SwiftUI App Lifecycle): Make SonarCloud happy
91c3404
adrien-coye
adrien-coye reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first quick review. There will be some conflicts with my PR, but nothing that cannot be solved IMO.

valentinperignon
valentinperignon reviewed Jun 30, 2023
View reviewed changes
Mail/RootView.swift Outdated Show resolved Hide resolved
Mail/RootView.swift Outdated Show resolved Hide resolved
Mail/Views/Thread/WebView.swift Outdated Show resolved Hide resolved
@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review June 30, 2023 08:56
@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner June 30, 2023 08:56
@PhilippeWeidmann PhilippeWeidmann marked this pull request as draft July 3, 2023 07:20
valentinperignon
valentinperignon reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Mail/LockedAppView.swift Outdated Show resolved Hide resolved
Mail/Views/Onboarding/OnboardingView.swift Outdated Show resolved Hide resolved
Mail/Views/Switch User/AccountListView.swift Outdated Show resolved Hide resolved
@PhilippeWeidmann
Merge branch 'master' into swiftui-app
48788aa 
# Conflicts:
#	Mail/AppDelegate.swift
#	Mail/SceneDelegate.swift
#	Mail/Views/NoMailboxView.swift
#	Mail/Views/Switch User/AccountView.swift
#	Mail/Views/Thread List/ThreadListModifiers.swift
adrien-coye
adrien-coye previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re reviewed more in details and found nothing special to say.
I also played with the app a bit, no issues there.
Let me know when it gets merged please 🙏

@PhilippeWeidmann
Merge branch 'master' into swiftui-app
c2477b4 
# Conflicts:
#	Mail/Views/Thread/WebView.swift
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review July 7, 2023 12:54
valentinperignon
valentinperignon approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run perf tests before merging

@PhilippeWeidmann PhilippeWeidmann merged commit 91ea015 into master Jul 10, 2023
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the swiftui-app branch July 10, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

@adrien-coye adrien-coye adrien-coye left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhilippeWeidmann @valentinperignon @adrien-coye