Mail share extension #830
Merged
Mail share extension #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct, thanks to some refactor using DI to abstract types not availlable in Extension mode feat: AccountManager is now availlable with DI instead of static ref.
feat: Present ComposeMessageView when sharing to ikMail
Merged
feat: share extension working with images from photo library
…t work in share ext.
… now displayed with a notification while using the share extension feat: abstract application state, so it builds in share extension. feat: abstract the way to present a Snackbar within the app, so it can use a Notification within shareExtension thanks to MessagePresentable
feat: use ApplicationStatable where possible
adrien-coye
force-pushed
the
shareExtension
branch
from
3b81ca7
to
f337a69
Compare
core: reworked closure base type to be more abstact
fix(attachments): cap max number of attachments to keep API happy
adrien-coye
force-pushed
the
shareExtension
branch
from
86ca4ae
to
258cbbe
Compare
… from the app or share extension it does make sense
adrien-coye
force-pushed
the
shareExtension
branch
from
79cb51a
to
986854d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
PhilippeWeidmann
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
ShareExtension setup for the kMail project.
NEW: Support the same files as input as kDrive.
Dependencies
Core PRCore UI PRTODO Core UI + Core PRBring back latest Core changes hereuse date as default name Coreuse date as default name CoreUIDetails
Wraps existing SwiftUI code, no way to use pure SwiftUI currently IMO.
Includes also: