Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Synchronous decoupled token store #897

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat: Synchronous decoupled token store #897

merged 1 commit into from
Jul 26, 2023

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann
Copy link
Member Author

Duplication issues will be resolved when merging #830

@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review July 25, 2023 11:20
@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner July 25, 2023 11:20
@PhilippeWeidmann PhilippeWeidmann force-pushed the token-store branch 3 times, most recently from 91f990b to 426539b Compare July 25, 2023 12:44
@PhilippeWeidmann PhilippeWeidmann mentioned this pull request Jul 25, 2023
Merged
valentinperignon
valentinperignon reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

MailCore/Cache/TokenStore.swift Show resolved Hide resolved
Mail/Views/Alerts/LogoutConfirmationView.swift Outdated Show resolved Hide resolved
Mail/Views/Switch User/AccountView.swift Show resolved Hide resolved
@PhilippeWeidmann PhilippeWeidmann force-pushed the token-store branch 2 times, most recently from 328f501 to 3eed700 Compare July 26, 2023 05:34
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@valentinperignon valentinperignon merged commit beacdee into master Jul 26, 2023
4 of 5 checks passed
@valentinperignon valentinperignon deleted the token-store branch July 26, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhilippeWeidmann @valentinperignon