Skip to content

Bugfix/shell icons path extension #569

Bugfix/shell icons path extension

Bugfix/shell icons path extension #569

Triggered via pull request November 1, 2023 07:53
Status Success
Total duration 2m 42s
Artifacts

build.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

33 warnings
build (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L50
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFile' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L51
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFile' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L97
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFileByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L98
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFileByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L122
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectory' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L123
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectory' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L160
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectoryByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L161
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectoryByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values. (https://xunit.net/xunit.analyzers/rules/xUnit2000)
build (macos-latest): src/Camelot.ViewModels.Windows/ShellIcons/WindowsShellIconsService.cs#L87
This call site is reachable on all platforms. 'Icon.ToBitmap()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build (macos-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L23
This call site is reachable on all platforms. 'Image.Width' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L50
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFile' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L51
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFile' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L97
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFileByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L98
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateFileByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L122
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectory' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L123
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectory' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L160
The literal or constant value Name should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectoryByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): tests/Camelot.ViewModels.Tests/Factories/FileSystemNodeViewModelFactoryTests.cs#L161
The literal or constant value FullPath should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'TestCreateDirectoryByPath' on type 'FileSystemNodeViewModelFactoryTests'. Swap the parameter values.
build (ubuntu-latest): src/Camelot.ViewModels.Windows/ShellIcons/WindowsShellIconsService.cs#L87
This call site is reachable on all platforms. 'Icon.ToBitmap()' is only supported on: 'windows'.
build (ubuntu-latest): src/Camelot.ViewModels.Windows/WinApi/IconExtractor.cs#L66
This call site is reachable on all platforms. 'Icon.ExtractAssociatedIcon(string)' is only supported on: 'windows'.
build (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L24
This call site is reachable on all platforms. 'ImageLockMode.ReadWrite' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/WindowsShellIconsService.cs#L87
This call site is reachable on all platforms. 'Icon.ToBitmap()' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L23
This call site is reachable on all platforms. 'Image.Width' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L28
This call site is reachable on all platforms. 'BitmapData.Height' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L27
This call site is reachable on all platforms. 'BitmapData.Scan0' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L23
This call site is reachable on all platforms. 'Image.Height' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L31
This call site is reachable on all platforms. 'Bitmap.UnlockBits(BitmapData)' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L32
This call site is reachable on all platforms. 'Image.Dispose()' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L24
This call site is reachable on all platforms. 'PixelFormat.Format32bppArgb' is only supported on: 'windows'.
build (windows-latest): src/Camelot.ViewModels.Windows/ShellIcons/SystemImageToAvaloniaBitmapConverter.cs#L30
This call site is reachable on all platforms. 'BitmapData.Stride' is only supported on: 'windows'.