Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use width to calculate height to avoid feedback loop #1829

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

AlasDiablo
Copy link
Collaborator

No description provided.

@AlasDiablo AlasDiablo added the 👷‍♂️ Work In Progress PR en cours de développement label Dec 6, 2023
@parmentf
Copy link
Contributor

parmentf commented Dec 6, 2023

src/app/js/formats/vega-lite/VegaLiteView.js Outdated Show resolved Hide resolved
Co-authored-by: François Parmentier <francois.parmentier@gmail.com>
@AlasDiablo AlasDiablo marked this pull request as ready for review December 6, 2023 13:50
@AlasDiablo AlasDiablo added 👷‍♂️ Ready For Review PR en attente de relecture et de validation and removed 👷‍♂️ Work In Progress PR en cours de développement labels Dec 6, 2023
@parmentf parmentf merged commit 5a93bbc into master Dec 6, 2023
9 checks passed
@parmentf parmentf deleted the fix-height-feedback-loop branch December 6, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants