Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI enhancements from #189 #198

Open
voborgus opened this issue Nov 13, 2021 · 2 comments
Open

UI enhancements from #189 #198

voborgus opened this issue Nov 13, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@voborgus
Copy link
Collaborator

voborgus commented Nov 13, 2021

Moved from #189
@spier commented:

There are still some other UI glitches in this area that could still be improved:

  • Bring the images of the Summits to the same size, or find other ways to make sure that event title etc are aligned
  • How to align the text if the title breaks into 2 rows?
  • How to align the Open/Watch buttons horizontally? Maybe that would get fixed together with (2) automatically?
  • How to prevent repetitive intros like "Join us for an InnerSource Commons Community Call ..."
@voborgus voborgus added the bug Something isn't working label Nov 13, 2021
@voborgus
Copy link
Collaborator Author

My thoughts:

Bring the images of the Summits to the same size, or find other ways to make sure that event title etc are aligned

The most valid way is to change the pictures. As a dirty workaround, I can suggest setting height via CSS for all images on these pages according to CSS breakpoints: 197px, 163px, etc. But IMHO it is too dirty and I would suggest not go with this way :)

How to align the text if the title breaks into 2 rows?

image

As an option, we can have the same bottom padding for all cases including one-line headers but maybe it's not so beautiful :(

How to align the Open/Watch buttons horizontally? Maybe that would get fixed together with (2) automatically?

If the column height is equal, the buttons are equal too:

image

How to prevent repetitive intros like "Join us for an InnerSource Commons Community Call ..."

Change text respectively or remove text from this page :)

@andrea-kyurchiev
Copy link
Collaborator

andrea-kyurchiev commented Apr 7, 2023

I've addressed

  • Bring the images of the Summits to the same size, or find other ways to make sure that event title etc are aligned
  • How to align the Open/Watch buttons horizontally? Maybe that would get fixed together with (2) automatically?

in #515

A possible fix for

  • How to align the text if the title breaks into 2 rows?

Would be giving the title a fixed/min height of 2 rows for example but this would sacrifice the space of the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants