Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese page update #566

Merged
merged 7 commits into from
Jun 19, 2023
Merged

Japanese page update #566

merged 7 commits into from
Jun 19, 2023

Conversation

yuhattor
Copy link
Member

@yuhattor yuhattor commented Jun 18, 2023 •
edited
Loading

Update translation related items

Please review and approve this!

Update translation consistency check GitHub Action

See the fixed implementation here
#564

Updated translation

Updated Japan page to the latest
#564

  • "InnerSource Commons" (content/en/_index.md)
  • "Members" (content/en/about/members.md)
  • "Board & Governance" (content/en/about/board/_index.md)
  • "InnerSource Stories" (content/en/stories/_index.md)
  • "InnerSource Services Directory" (content/en/community/services.md)

@yuhattor yuhattor requested a review from a team as a code owner June 18, 2023 12:15
@yuhattor yuhattor linked an issue Jun 18, 2023 that may be closed by this pull request
🇯🇵 Japanese: Content Consistency Issue #564
Closed
@yuhattor
Copy link
Member Author

@bory_kb Could you please see and confirm if it's okay:)
Thanks!

@bory-kb
Copy link

bory-kb commented Jun 18, 2023

LGTM!!

spier
spier approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 2 members of the Japanese community are happy with the translation, then I am sure this is good to go live 👍

Thank you for making and keeping the site available for people that are more comfortable with Japanese than with English!

@spier spier merged commit d6bbc54 into master Jun 19, 2023
8 checks passed
@spier spier deleted the japanese-page-update branch June 19, 2023 06:57
@yuhattor
Copy link
Member Author

Thank you!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🇯🇵 Japanese: Content Consistency Issue
3 participants
@yuhattor @bory-kb @spier