refactor: removes aliases from announcements #780
Conversation
|
Will this break existing links? |
|
Not within the website, no. Only if any of the announcements are linked anywhere external (ex. LinkedIn) |
|
Current behavior when visiting a page with an alias is for the page to be displayed in English (albeit with a “zh” in the URL path). Is that correct? |
|
@rrrutledge yes, its the "zh" in front that changes the language |
|
Thanks for looking at this, @andrea-kyurchiev. I have to ask my question again, though, because I don’t think it’s been answered, yet. Today, when a person visits a page alias, will they see the page rendered in English or Chinese? |
|
@rrrutledge the page itself will be in English as none of the announcements have a Chinese translation but the website's locale will be changed to Chinese |
|
OK - got it. One more question, now. After merging this PR, if a person visits a page alias, what will they see? 404 page? |
|
@rrrutledge yes, I believe so |
|
In that case let’s not do this change. Landing at a page with English text (albeit with Chinese locale) is a better experience than landing on a 404 page. |
A workaround for #521 until we find a permanent fix. Seems that this only happens if aliases are used for announcements