Merge branch 'develop'

* develop: fix not spreading the list of args of the scenario when filtering
Innmind · Apr 4, 2020 · 4feed6b · 4feed6b
2 parents 45808b9 + 4d76872
commit 4feed6b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/PHPUnit/Scenario.php b/src/PHPUnit/Scenario.php
@@ -64,7 +64,9 @@ public function disableShrinking(): self
     public function filter(callable $predicate): self
     {
         $self = clone $this;
-        $self->set = $this->set->filter($predicate);
+        $self->set = $this->set->filter(
+            static fn(array $args): bool => $predicate(...$args),
+        );
 
         return $self;
     }

diff --git a/tests/PHPUnit/ScenarioTest.php b/tests/PHPUnit/ScenarioTest.php
@@ -59,8 +59,8 @@ public function testAllowToOnlyTakeACertainNumberOfScenarios()
     public function testAllowAFilterCanBeAppliedOnTheScenario()
     {
         $scenario1 = new Scenario(Integers::any(), Integers::any());
-        $scenario2 = $scenario1->filter(static function($value): bool {
-            return ($value[0] + $value[1]) % 2 === 0;
+        $scenario2 = $scenario1->filter(static function($a, $b): bool {
+            return ($a + $b) % 2 === 0;
         });
 
         $this->assertNotSame($scenario1, $scenario2);