fix swallowed exceptions in properties

Innmind · Jan 28, 2024 · e3477f0 · e3477f0
1 parent 694c5fd
commit e3477f0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [Unreleased]
+
+### Fixed
+
+- Thrown exceptions in properties weren't failing proofs
+
 ## 5.6.1 - 2023-12-02
 
 ### Changed

diff --git a/src/Runner/Proof/Scenario/Properties.php b/src/Runner/Proof/Scenario/Properties.php
@@ -33,7 +33,7 @@ public function __invoke(Assert $assert): mixed
         } catch (Assert\Failure $e) {
             throw $e;
         } catch (\Throwable $e) {
-            $assert->not()->throws(static fn() => $e);
+            $assert->not()->throws(static fn() => throw $e);
         }
 
         return null;

diff --git a/src/Runner/Proof/Scenario/Property.php b/src/Runner/Proof/Scenario/Property.php
@@ -33,7 +33,7 @@ public function __invoke(Assert $assert): mixed
         } catch (Assert\Failure $e) {
             throw $e;
         } catch (\Throwable $e) {
-            $assert->not()->throws(static fn() => $e);
+            $assert->not()->throws(static fn() => throw $e);
         }
 
         return null;