Fix list pagination and proofs conflict #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
4.1.1
release a fix to paginate the listing of paths. However it fails in some scenarii due to the characters contained in the continuation token.Solution
Use the built-in PHP function to build the query string with the RFC3986 format.
Note
This PR also changes the bucket used to run the filesystem properties due to the fact that the other proofs can generate a directory and a file with the same name inside the bucket. This scenario is not supported by the properties.
This specific scenario has been generated in the bucket currently used to run the proofs, and the properties fail.
2 new buckets have been created to separate the avoid behaviours conflict between proofs and properties.