Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy Integration #1

Open
togetherwithasteria opened this issue Dec 21, 2022 · 2 comments
Open

Bevy Integration #1

togetherwithasteria opened this issue Dec 21, 2022 · 2 comments
Labels
area:api API enhancement New feature or request

Comments

@togetherwithasteria
Copy link
Contributor

togetherwithasteria commented Dec 21, 2022 •
edited
Loading

We will need to have our code compatible with Bevy's ECS API. Then we can easily implement it in a separate crate.

Implementation Overview

Bevy uses an Entity Component System (ECS) system.

For its windowing events, Bevy doesn't pass the events from Winit, but send its own event data listed in bevy::window using Bevy ECS.

For the rendering part, bevy provides an API trough the Renderer Sub-App.
@Speykious Speykious added the enhancement New feature or request label Dec 21, 2022
@Speykious
Copy link
Member

We should probably focus on making the WGPU renderer first (#2), since that was planned from the start.

@togetherwithasteria
Copy link
Contributor Author

togetherwithasteria commented Dec 21, 2022 •
edited
Loading

We should probably focus on making the WGPU renderer first (#2), since that was planned from the start.

Yup! But let's write it with Bevy ECS in mind, so we don't have to rewrite things.

Speykious added a commit that referenced this issue Dec 27, 2022
@Speykious @LunaTheFoxgirl
Merge latest changes from main (#1)
efa7055 
* Remove Serde

* Remove unnecessary structures created for serde

* Remove unnecessary features

* Enums aren't that bad after all...

* Reorganize nodes in less files for readability

* Rename `parsers` module to `formats`

* Add manual deserialization

* Prefix types with `Ext` when it makes sense

* Restructure `Binding` struct

* Finish serialization

* Update README

* Create `JsonObject` wrapper

* Add decent-ish error handling

* Fix bug casualties

* Fix stencil

* Put stencil disabling inside debug group

* Composite shaders: I forgor 💀

* Remove now useless derive macro

* cargo fmt

* Update README

* simplify renderer generics

* Add documentation

Co-authored-by: Luna <cli-luna@protonmail.com>
@orowith2os orowith2os mentioned this issue Mar 5, 2023
Open
@Speykious Speykious added the area:api API label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Speykious @togetherwithasteria