Make Parameters work #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speykious
commented
Apr 20, 2023
src/math/interp.rs
Outdated
Comment on lines
28
to
46
| pub struct InterpRange<T> { | ||
| pub beg: T, | ||
| pub end: T, | ||
| beg: T, | ||
| end: T, | ||
| } | ||
|
|
||
| impl<T> InterpRange<T> { | ||
| #[inline] | ||
| pub fn new(beg: T, end: T) -> Self { | ||
| Self { beg, end } | ||
| } | ||
|
|
||
| pub fn begin(self) -> T { | ||
| self.beg | ||
| } | ||
|
|
||
| pub fn end(self) -> T { | ||
| self.end | ||
| } | ||
| } |
There was a problem hiding this comment.
There is no benefit to this
There was a problem hiding this comment.
Was there when I added an assert in new for begin <= end, I'll revert
Comment on lines
+5
to
6
| #[derive(Clone, Copy, Debug)] | ||
| pub struct Transform { |
There was a problem hiding this comment.
Are you sure it's ok to make the Transform copy? It seems like it's already a heavy struct
There was a problem hiding this comment.
Hmmm ideally we shouldn't copy Transform that much yeah, but idk if making if !Copy is the way to achieve that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @carbotaniuman