Use the attohttpc crate instead of ureq #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has some implications for Error: - because attohttpc doesn't distinguish between errors when serializing or deserializing request/response data, Error::RequestJson and Error::ResponseJson have been merged into Error::Json. In practice this shouldn't matter much because request data is (usually) well-formed. - attohttpc also doesn't return errors for HTTP responses with statuses in the [400-599] range, so manual conversion to an error is needed (this now happens in ResponseType::from_response).
shymega
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has some implications for
Error:attohttpcdoesn't distinguish between errorswhen serializing or deserializing request/response
data,
Error::RequestJsonandError::ResponseJsonhavebeen merged into
Error::Json. In practice this shouldn'tmatter much because request data is (usually) well-formed.
attohttpcalso doesn't return errors for HTTP responseswith statuses in the [400-599] range, so manual conversion
to an error is needed (this now happens in
ResponseType::from_response).Closes #3.