Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the attohttpc crate instead of ureq #7

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Use the attohttpc crate instead of ureq #7

merged 2 commits into from
Sep 1, 2021

Commits on Sep 1, 2021

  1. Use the attohttpc crate instead of ureq. 

    This has some implications for Error:
- because attohttpc doesn't distinguish between errors
  when serializing or deserializing request/response
  data, Error::RequestJson and Error::ResponseJson have
  been merged into Error::Json. In practice this shouldn't
  matter much because request data is (usually) well-formed.
- attohttpc also doesn't return errors for HTTP responses
  with statuses in the [400-599] range, so manual conversion
  to an error is needed (this now happens in ResponseType::from_response).
    @InputUsername
    InputUsername committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c49f401 View commit details
    Browse the repository at this point in the history

  2. Run rustfmt

    @InputUsername
    InputUsername committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c1bb3f3 View commit details
    Browse the repository at this point in the history