Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC : extra params #378

Merged
merged 5 commits into from
Feb 9, 2024
Merged

OIDC : extra params #378

merged 5 commits into from
Feb 9, 2024

Conversation

olevitt
Copy link
Contributor

@olevitt olevitt commented Feb 7, 2024

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 7, 2024
@olevitt olevitt added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Feb 7, 2024
Copy link
Contributor

@johnksv johnksv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this field be added to Region.OIDCConfiguration as well? Such that it can be returned in ConfigurationController L52.
Also, regarding the name. Do you think extraParams is OK, or should it be emphasised that it is extraQueryParams (or is that a frontend detail)?

README.md Outdated Show resolved Hide resolved
@garronej
Copy link
Contributor

garronej commented Feb 7, 2024

@johnksv @olevitt I also would prefer oidc.extra-query-params or oidc.extra-url-redirect-query-params.
About Region.OIDCConfiguration I think it would be overkill. Most of the time all client are on the same realm so there's SSO, it's the Onyxia oidc client that will initiate the redirect.

@olevitt
Copy link
Contributor Author

olevitt commented Feb 7, 2024

I think we can do the same as for other OIDC configuration : make this parameter optionnal for additional OIDCConfiguration so that it's only needed once but can still be overriden in case it's needed

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 7, 2024
@garronej
Copy link
Contributor

garronej commented Feb 7, 2024

@olevitt ok works for me I guess I just need to update the doc

Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@olevitt olevitt removed the documentation Improvements or additions to documentation label Feb 9, 2024
@olevitt olevitt merged commit dc1c552 into main Feb 9, 2024
8 checks passed
@olevitt olevitt deleted the oidc-extra-params branch February 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants