Add support for oidc extra params from api #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnksv
force-pushed
the
oidc-extra-params
branch
from
015a755
to
58f3d77
Compare
In some use cases the user want to specify extra query paramas. E.g. prompt type. This can now be done by specifying a json object in the env variable Get oidc extra query params field from api
johnksv
force-pushed
the
oidc-extra-params
branch
from
58f3d77
to
6d3ca34
Compare
|
|
Rebased to make changes align with upcoming changes in API (InseeFrLab/onyxia-api#378). |
johnksv
changed the title
|
Looking good! there's just a few litle details to adress. I'll fix them and merge tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some use cases the user want to specify extra query parameters. E.g. prompt type. This can now be done by specifying the parameters in the API. The frontend will use those parameters and send it along in the oidc flow.
Draft PR for visibility until code is ready for review.