Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for overwriteListEnumWith property #434

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

trygu
Copy link
Contributor

@trygu trygu commented Jun 14, 2024

Added support for overwriteListEnumWith in the Properties class in the API. Hopefully resolves the last bit of InseeFrLab/onyxia#819

Based on possibly faulty assumptions, so be gentle

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@olevitt
Copy link
Contributor

olevitt commented Jun 14, 2024

@trygu Thank you !
I took the liberty to change the type from String to Object as the UI accepts other structure such as arrays

@olevitt olevitt merged commit 4cd808f into InseeFrLab:main Jun 14, 2024
5 checks passed
@trygu
Copy link
Contributor Author

trygu commented Jun 14, 2024

Excellent. I contemplated doing it since you had an open PR on it already but just kept it the way it was

@trygu trygu deleted the support-for-overwritelistenum-property branch June 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants