Revert "Fix reified type for createScope, getScopeId, getScopeName"

This reverts commit 64d5408.
InsertKoinIO · Jun 5, 2023 · d6c8f87 · d6c8f87
1 parent 40f6286
commit d6c8f87
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/core/koin-core/src/commonMain/kotlin/org/koin/core/Koin.kt b/core/koin-core/src/commonMain/kotlin/org/koin/core/Koin.kt
@@ -206,7 +206,7 @@ class Koin {
      * Create a Scope instance
      * @param scopeDefinitionName
      */
-    inline fun <reified T : KoinScopeComponent> createScope(t: T): Scope {
+    fun <T : KoinScopeComponent> createScope(t: T): Scope {
         val scopeId = t.getScopeId()
         val qualifier = t.getScopeName()
         return scopeRegistry.createScope(scopeId, qualifier, null)

diff --git a/core/koin-core/src/commonMain/kotlin/org/koin/core/component/KoinScopeComponent.kt b/core/koin-core/src/commonMain/kotlin/org/koin/core/component/KoinScopeComponent.kt
@@ -38,16 +38,16 @@ interface KoinScopeComponent : KoinComponent {
     }
 }
 
-inline fun <reified T : Any> T.getScopeId() = T::class.getFullName() + "@" + this.hashCode()
-inline fun <reified T : Any>T.getScopeName() = TypeQualifier(T::class)
+fun <T : Any> T.getScopeId() = this::class.getFullName() + "@" + this.hashCode()
+fun <T : Any> T.getScopeName() = TypeQualifier(this::class)
 
-inline fun <reified T : KoinScopeComponent> T.createScope(source: Any? = null): Scope {
+fun <T : KoinScopeComponent> T.createScope(source: Any? = null): Scope {
     return getKoin().createScope(getScopeId(), getScopeName(), source)
 }
 
-inline fun <reified T : KoinScopeComponent> T.getScopeOrNull(): Scope? {
+fun <T : KoinScopeComponent> T.getScopeOrNull(): Scope? {
     return getKoin().getScopeOrNull(getScopeId())
 }
 
-inline fun <reified T: KoinScopeComponent> T.newScope() = lazy { createScope() }
-inline fun <reified T : KoinScopeComponent> T.getOrCreateScope() = lazy { getScopeOrNull() ?: createScope() }
+fun <T : KoinScopeComponent> T.newScope() = lazy { createScope() }
+fun <T : KoinScopeComponent> T.getOrCreateScope() = lazy { getScopeOrNull() ?: createScope() }
diff --git a/core/koin-core/src/commonTest/kotlin/org/koin/core/ObjectScopeTest.kt b/core/koin-core/src/commonTest/kotlin/org/koin/core/ObjectScopeTest.kt
@@ -83,7 +83,6 @@ class ObjectScopeTest {
     @Test
     fun `scope from instance object`() {
         val koin = startKoin {
-            printLogger(Level.DEBUG)
             modules(module {
                 single { A() }
                 scope<A> {