Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning about ProGuard #267

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

jschmid
Copy link
Contributor

@jschmid jschmid commented Oct 11, 2018

I had a problem after using create() on Android. My debug builds always worked, but then it failed on a release build.
This was because my classes' constructor where removed by R8.

I added a warning in the documentation about it.

@arnaudgiuliani arnaudgiuliani added this to the 1.0.2 milestone Oct 16, 2018
Copy link
Member

@arnaudgiuliani arnaudgiuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok !

@arnaudgiuliani arnaudgiuliani changed the base branch from master to 1.0.2 October 24, 2018 14:01
@arnaudgiuliani arnaudgiuliani merged commit cc97a2e into InsertKoinIO:1.0.2 Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted accepted to be developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants