COMP: Update SpatialObjects to correct const-ness #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
dzenanz
approved these changes
Aug 10, 2021
BUG: Must add a point to a spatial object before requesting world info A spatial object point has a position in object space, but until it is added to a spatial object (which potentially exists in a hierarchy of objects with parent/child transforms) the point does not have a position in world space. So, the test has been updated to add a point to an object before asking for that point's world space position.
|
I am verifying these changes with TubeTK. Please hold on merging. Almost done... |
|
Awesome, thanks, @aylward ! I will integrate after CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpatialObjects can now return a const list of their children, and SpatialObjectWriter accepts a const object.
Furthermore, updated test...A spatial object point has a position in object space, but until it is added to a spatial object (which potentially exists in a hierarchy of objects with parent/child transforms) the point does not have a position in world space. So, the test has been updated to add a point to an object before asking for that point's world space position.