Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add ITKVkFFTBackend remote module #3363

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 0 additions & 100 deletions CMake/FindOpenCL.cmake

This file was deleted.

10 changes: 7 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -710,9 +710,13 @@ if("${CMAKE_GENERATOR}" MATCHES "Xcode|Visual Studio|KDevelop")
function(itk_organize_targets dir folder)
itk_get_all_targets_recursive(targets ${dir})
foreach(t ${targets})
get_target_property(f ${t} SOURCE_DIR)
string(REPLACE ${dir} "" f ${f})
set_target_properties (${t} PROPERTIES FOLDER "${folder}/${f}")
# INTERFACE_LIBRARY warns about non-whitelisted properties for CMake < 3.19
get_target_property(type ${t} TYPE)
if (NOT "${type}" STREQUAL "INTERFACE_LIBRARY")
get_target_property(f ${t} SOURCE_DIR)
string(REPLACE ${dir} "" f ${f})
set_target_properties (${t} PROPERTIES FOLDER "${folder}/${f}")
endif()
endforeach()
endfunction()
macro(itk_get_all_targets_recursive targets dir)
Expand Down
50 changes: 50 additions & 0 deletions Modules/Remote/VkFFTBackend.remote.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
#-- # Grading Level Criteria Report
#-- EVALUATION DATE: 2022-04-06
#-- EVALUATORS: [Tom Birdsong]
#--
#-- ## Compliance level 5 star (AKA ITK main modules, or remote modules that could become core modules)
#-- - [ ] Widespread community dependance
#-- - [ ] Above 90% code coverage
#-- - [X] CI dashboards and testing monitored rigorously
#-- - [X] Key API features are exposed in wrapping interface
#-- - [ ] All requirements of Levels 4,3,2,1
#--
#-- ## Compliance Level 4 star (Very high-quality code, perhaps small community dependance)
#-- - [X] Meets all ITK code style standards
#-- - [ ] No external requirements beyond those needed by ITK proper
#-- - [X] Builds and passes tests on all supported platforms within 1 month of each core tagged release
tbirdso marked this conversation as resolved.
Show resolved Hide resolved
#-- - [X] Windows Shared Library Build with Visual Studio
#-- - [X] Mac with clang compiller
#-- - [X] Linux with gcc compiler
#-- - [X] Active developer community dedicated to maintaining code-base
#-- - [ ] 75% code coverage demonstrated for testing suite
#-- - [X] Continuous integration testing performed
#-- - [X] All requirements of Levels 3,2,1
#--
#-- ## Compliance Level 3 star (Quality beta code)
#-- - [X] API | executable interface is considered mostly stable and feature complete
#-- - [X] 10% C0-code coverage demonstrated for testing suite
#-- - [X] Some tests exist and pass on at least some platform
#-- - [X] All requirements of Levels 2,1
#--
#-- ## Compliance Level 2 star (Alpha code feature API development or niche community/exectution environment dependance )
#-- - [X] Compiles for at least 1 niche set of execution envirionments, and perhaps others
#-- (may depend on specific external tools like a java environment, or specific external libraries to work )
#-- - [X] All requirements of Levels 1
#--
#-- ## Compliance Level 1 star (Pre-alpha features under development and code of unkown quality)
#-- - [X] Code complies on at least 1 platform
#--
#-- ## Compliance Level 0 star ( Code/Feature of known poor-quality or deprecated status )
#-- - [ ] Code reviewed and explicitly identified as not recommended for use
#--
#-- ### Please document here any justification for the criteria above
# Code style enforced by clang-format on 2020-02-19, and clang-tidy modernizations completed

# Contact: Tom Birdsong <tom.birdsong@kitware.com>
itk_fetch_module(VkFFTBackend
"ITK FFT accelerated backends using the VkFFT library for Vulkan/CUDA/HIP/OpenCL compatibility."
MODULE_COMPLIANCE_LEVEL 3
GIT_REPOSITORY ${git_protocol}://github.com/InsightSoftwareConsortium/ITKVkFFTBackend.git
GIT_TAG 55aa53ccf4b138066ddc8c4541946446424c76c6
)