Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Add in-class {} initializers to classes with override = default #3917

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Feb 8, 2023

Added in-class {} default member initializers to data members of classes that have a destructor declared override = default.

Follow-up to pull request #3913 commit 5c97b76
"STYLE: Add in-class {} initializers to classes with virtual functions"

Added in-class `{}` default member initializers to data members of classes
that have a destructor declared `override = default`.

Follow-up to pull request InsightSoftwareConsortium#3913
commit 5c97b76
"STYLE: Add in-class `{}` initializers to classes with virtual functions"
@github-actions github-actions bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) labels Feb 8, 2023
@N-Dekker
Copy link
Contributor Author

N-Dekker commented Feb 8, 2023

Sorry, I had previously overlooked these cases. Obviously my script wasn't yet finished: https://gist.github.com/N-Dekker/738d28b8d7528a32c12e7a129160b00f

@N-Dekker N-Dekker marked this pull request as ready for review February 9, 2023 20:40
@dzenanz dzenanz merged commit 5635b75 into InsightSoftwareConsortium:master Feb 13, 2023
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Feb 23, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Feb 23, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Feb 25, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Feb 25, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Feb 25, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Feb 25, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 1, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request InsightSoftwareConsortium#3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 4, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request InsightSoftwareConsortium#3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"

pull request InsightSoftwareConsortium#3945
"STYLE: Add in-class `{}` member initializers having trailing comments"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 6, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request InsightSoftwareConsortium#3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"

pull request InsightSoftwareConsortium#3945
"STYLE: Add in-class `{}` member initializers having trailing comments"
dzenanz pushed a commit that referenced this pull request Mar 20, 2023
The script that was used for the following pull requests:

pull request #3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request #3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request #3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request #3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"

pull request #3945
"STYLE: Add in-class `{}` member initializers having trailing comments"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants