Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Add in-class {} member initializers to 3-letter data members #3941

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Mar 1, 2023

Previous commits that added {} initializers to data members by means of regular expressions had overlooked three-letter identifiers, like m_E and m_I.

Follow-up to pull request #3851 commit 5e2c49f
"STYLE: Add in-class {} member initializers to objects created by New()"

Previous commits that added `{}` initializers to data members by means of
regular expressions had overlooked three-letter identifiers, like `m_E` and
`m_I`.

Follow-up to pull request InsightSoftwareConsortium#3851
commit 5e2c49f
"STYLE: Add in-class `{}` member initializers to objects created by New()"
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Mar 1, 2023
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny oversight 😄

N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 1, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request InsightSoftwareConsortium#3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"
@N-Dekker N-Dekker marked this pull request as ready for review March 1, 2023 21:46
@jhlegarreta jhlegarreta merged commit b62a363 into InsightSoftwareConsortium:master Mar 3, 2023
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 4, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request InsightSoftwareConsortium#3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"

pull request InsightSoftwareConsortium#3945
"STYLE: Add in-class `{}` member initializers having trailing comments"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 6, 2023
The script that was used for the following pull requests:

pull request InsightSoftwareConsortium#3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request InsightSoftwareConsortium#3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request InsightSoftwareConsortium#3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request InsightSoftwareConsortium#3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"

pull request InsightSoftwareConsortium#3945
"STYLE: Add in-class `{}` member initializers having trailing comments"
dzenanz pushed a commit that referenced this pull request Mar 20, 2023
The script that was used for the following pull requests:

pull request #3851
"STYLE: Add in-class `{}` member initializers to objects created by New()"

pull request #3913
"STYLE: Add in-class `{}` initializers to classes with virtual functions"

pull request #3917
"STYLE: Add in-class `{}` initializers to classes with override = default"

pull request #3941
"STYLE: Add in-class `{}` member initializers to 3-letter data members"

pull request #3945
"STYLE: Add in-class `{}` member initializers having trailing comments"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants