COMP: gcc-13 compatability #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using gcc-13 ITK does not compile as discussed in this form entry: https://discourse.itk.org/t/building-itk-error-with-algorithim-module/5927/9. Was able to be fixed thanks to @dzenanz with the inclusion of <cstdint> to itkMathematicalMorphologyEnums.h
github-actions
bot
added
type:Compiler
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for contributing a pull request! 🙏
Welcome to the ITK community! 🤗👋☀️
We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖
dzenanz
approved these changes
May 8, 2023
hjmjohnson
approved these changes
May 9, 2023
|
FYI, I'm just proposing is a little style adjustment to this fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using gcc-13 ITK does not compile as discussed in this form entry: (https://discourse.itk.org/t/building-itk-error-with-algorithim-module/5927/9). Was able to be fixed thanks to @dzenanz with the inclusion of to itkMathematicalMorphologyEnums.h and specifying std::uint8_t on line 41.