STYLE: Remove initial << insertion from itkExceptionMacro(<< " calls
#4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the C++ preprocessor append the specified literal string to the error message, instead of doing the equivalent `<<` insertion at run-time. Aims to shorten the code a little bit, and improve consistency. The code base already had more than 750 `itkExceptionMacro` calls that passed a literal string directly, without having `<<` at its left side.
github-actions
bot
added
area:Python wrapping
dzenanz
approved these changes
May 30, 2023
issakomi
reviewed
May 31, 2023
| @@ -1211,14 +1211,14 @@ GDCMImageIO::Write(const void * buffer) | |||
| outpixeltype.SetPixelRepresentation(static_cast<unsigned short>(std::stoi(pixelRep.c_str()))); | |||
| if (this->GetNumberOfComponents() != 1) | |||
| { | |||
| itkExceptionMacro(<< "Sorry Dave I can't do that"); | |||
| itkExceptionMacro("Sorry Dave I can't do that"); | |||
There was a problem hiding this comment.
“I'm sorry, Dave. I'm afraid I can't do that,” said HAL 9000
(c) 2001: A Space Odyssey
There was a problem hiding this comment.
Thanks for the reference, Mihail! Honestly I doubt if such an error message is very helpful to the user. In general, I'm not a fan of "funny" error messages. Unless they really help to communicate to the user what's going wrong. But anyway, that's beyond the scope of this pull request!
There was a problem hiding this comment.
I don't use funny error messages too. I am not sure what this one means, just reminded me of the citation from the movie, but it may be something else.
There was a problem hiding this comment.
Maybe it is an error message which is not supposed to be reachable by the GDCM's users?
There was a problem hiding this comment.
Maybe... but then I guess the message is only for someone named Dave 😸 Thanks for merging @dzenanz !
Oops, I see now: Meaning that the PR has actually added more lines of code! Oops! I'm sorry 😸 ! |
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 1, 2023
Follow-up to pull request InsightSoftwareConsortium#4057 commit 89beb04 "STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 2, 2023
Follow-up to pull request InsightSoftwareConsortium#4057 commit 89beb04 "STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls" Aims to shorten the code a little bit, and improve consistency. The code base already had more than 500 `itkDebugMacro` calls that passed a literal string as first argument directly, without having `<<` at its left side.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 2, 2023
Follow-up to pull request InsightSoftwareConsortium#4057 commit 89beb04 "STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls" Aims to shorten the code a little bit, and improve consistency. The code base already had more than 80 `itkWarningMacro` calls that passed a literal string as first argument directly, without having `<<` at its left side.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Jun 2, 2023
Follow-up to pull request InsightSoftwareConsortium#4057 commit 89beb04 "STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls" Aims to shorten the code a little bit, and improve consistency. The code base already had seven `itkGenericOutputMacro` calls that passed a literal string as first argument directly, without having `<<` at its left side.
dzenanz
pushed a commit
that referenced
this pull request
Jun 2, 2023
Follow-up to pull request #4057 commit 89beb04 "STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls" Aims to shorten the code a little bit, and improve consistency. The code base already had more than 500 `itkDebugMacro` calls that passed a literal string as first argument directly, without having `<<` at its left side.
dzenanz
pushed a commit
that referenced
this pull request
Jun 2, 2023
Follow-up to pull request #4057 commit 89beb04 "STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls" Aims to shorten the code a little bit, and improve consistency. The code base already had more than 80 `itkWarningMacro` calls that passed a literal string as first argument directly, without having `<<` at its left side.
dzenanz
pushed a commit
that referenced
this pull request
Jun 2, 2023
Follow-up to pull request #4057 commit 89beb04 "STYLE: Remove initial `<<` insertion from `itkExceptionMacro(<< "` calls" Aims to shorten the code a little bit, and improve consistency. The code base already had seven `itkGenericOutputMacro` calls that passed a literal string as first argument directly, without having `<<` at its left side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the C++ preprocessor append the specified literal string to the error message, instead of doing the equivalent
<<insertion at run-time.Aims to shorten the code a little bit, and improve consistency. The code base already had more than 750
itkExceptionMacrocalls that passed a literal string directly, without having<<at its left side.