Check thisClass argument of GetNameOfClass macro calls, fix class name returned by GetNameOfClass() overrides
#4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BinaryImageToLevelSetImageAdaptor::GetNameOfClass()` erroneously returned "BinaryImageToLevelSetImageAdaptorBase", while it should just return "BinaryImageToLevelSetImageAdaptor". Fixed by passing the correct class name to `itkOverrideGetNameOfClassMacro`. Bug introduced with commit ab469f5 "ENH: Refactor BinaryImageToLevelSetImageAdaptor classes", 2011-11-11.
Fixed the class names returned by the `GetNameOfClass()` member functions of `amoebaTestF2` (from "itkAmoebaOptimizerTest") and `LBFGSCostFunction` (from "itkLBFGSOptimizerTest"), by passing the correct class name to `itkOverrideGetNameOfClassMacro`.
Asserted in both `itkVirtualGetNameOfClassMacro` and `itkOverrideGetNameOfClassMacro` that `thisClass` is indeed the name of the class that contains the macro call. The assert helped finding three classes whose `GetNameOfClass()` member function returned the wrong name.
github-actions
bot
added
type:Testing
dzenanz
approved these changes
Dec 27, 2023
hjmjohnson
approved these changes
Jan 2, 2024
|
This line |
|
PR open: InsightSoftwareConsortium/ITKMontage#224. |
2 tasks
dzenanz
added a commit
to dzenanz/ITKModuleTemplate
that referenced
this pull request
Jan 25, 2024
jhlegarreta
pushed a commit
to jhlegarreta/ITKModuleTemplate
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a compile-time check on the
thisClassargument of bothitkVirtualGetNameOfClassMacroanditkOverrideGetNameOfClassMacro. Fixed the class name returned by threeGetNameOfClass()overrides, includingBinaryImageToLevelSetImageAdaptor::GetNameOfClass()