Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check thisClass argument of GetNameOfClass macro calls, fix class name returned by GetNameOfClass() overrides #4378

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Check thisClass argument of GetNameOfClass macro calls, fix class name returned by GetNameOfClass() overrides #4378

merged 3 commits into from
Jan 2, 2024

Commits on Dec 27, 2023

  1. BUG: Fix name BinaryImageToLevelSetImageAdaptor::GetNameOfClass() 

    `BinaryImageToLevelSetImageAdaptor::GetNameOfClass()` erroneously returned
"BinaryImageToLevelSetImageAdaptorBase", while it should just return
"BinaryImageToLevelSetImageAdaptor". Fixed by passing the correct class name to
`itkOverrideGetNameOfClassMacro`.

Bug introduced with commit ab469f5
"ENH: Refactor BinaryImageToLevelSetImageAdaptor classes", 2011-11-11.
    @N-Dekker
    N-Dekker committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    c7066ec View commit details
    Browse the repository at this point in the history

  2. BUG: Fix name returned by GetNameOfClass() in Optimizer tests 

    Fixed the class names returned by the `GetNameOfClass()` member functions of
`amoebaTestF2` (from "itkAmoebaOptimizerTest") and `LBFGSCostFunction` (from
"itkLBFGSOptimizerTest"), by passing the correct class name to
`itkOverrideGetNameOfClassMacro`.
    @N-Dekker
    N-Dekker committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    927243d View commit details
    Browse the repository at this point in the history

  3. ENH: Check thisClass argument of GetNameOfClass macro calls 

    Asserted in both `itkVirtualGetNameOfClassMacro` and
`itkOverrideGetNameOfClassMacro` that `thisClass` is indeed the name of the
class that contains the macro call.

The assert helped finding three classes whose `GetNameOfClass()` member function
returned the wrong name.
    @N-Dekker
    N-Dekker committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    213ab8d View commit details
    Browse the repository at this point in the history