Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: ITKVtkGlue only requires rendering libraries when needed #765

Merged
merged 1 commit into from
Apr 25, 2019
Merged

ENH: ITKVtkGlue only requires rendering libraries when needed #765

merged 1 commit into from
Apr 25, 2019

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Apr 24, 2019

Enable the use of ITKVtkGlue functionality that does not require
rendering when VTK was built with VTK_RENDERING_BACKEND set to None.

Addresses #714

@romangrothausmann additional testing would be appreciated 🙇‍♂️ .

@thewtex
Copy link
Member Author

thewtex commented Apr 24, 2019

@dzenanz this also addresses the issue that ITKVtkGlue_VTK_LIBRARIES was not set for newer VTK... this may help address #739, but I have not tested on Windows.

romangrothausmann added a commit to romangrothausmann/ITK-VTK_CLIs that referenced this pull request Apr 25, 2019
@romangrothausmann
check if ITK-PR #765 can cope with VTK_RENDERING_BACKEND=None:
72f31dd 
InsightSoftwareConsortium/ITK#765
https://help.github.com/en/articles/checking-out-pull-requests-locally
https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request
@romangrothausmann
Copy link
Member

Many thanks @thewtex for that contribution, works for me like a charm.
With
romangrothausmann/ITK-VTK_CLIs@72f31dd
no errors any more:
https://gitlab.com/romangrothausmann/ITK-VTK_CLIs/pipelines/58330104
VTK-8.1.2 also works:
romangrothausmann/ITK-VTK_CLIs@1af1df7
https://gitlab.com/romangrothausmann/ITK-VTK_CLIs/pipelines/58335538

@romangrothausmann
Copy link
Member

Also VTK-8.2.0:
romangrothausmann/ITK-VTK_CLIs@6386ccf
https://gitlab.com/romangrothausmann/ITK-VTK_CLIs/pipelines/58340685

@thewtex
Copy link
Member Author

thewtex commented Apr 25, 2019 •
edited
Loading

@fbudin69500 @romangrothausmann thanks for the reviews and testing!

Pushing a fix for the tests, then merging.

@thewtex
ENH: ITKVtkGlue only requires rendering libraries when needed
ec81ae6 
Enable the use of ITKVtkGlue functionality that does not require
rendering when VTK was built with VTK_RENDERING_BACKEND set to None.
@thewtex thewtex merged commit dc4419d into InsightSoftwareConsortium:master Apr 25, 2019
@thewtex thewtex deleted the vtk-rendering-optional branch April 25, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbudin69500 fbudin69500 fbudin69500 approved these changes

@phcerdan phcerdan Awaiting requested review from phcerdan

@dzenanz dzenanz Awaiting requested review from dzenanz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thewtex @romangrothausmann @fbudin69500