Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering part of VTK Glue #739

Closed
dzenanz opened this issue Apr 16, 2019 · 7 comments · Fixed by #778
Closed

Fix rendering part of VTK Glue #739

dzenanz opened this issue Apr 16, 2019 · 7 comments · Fixed by #778
Assignees
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Milestone

Comments

@dzenanz
Copy link
Member

dzenanz commented Apr 16, 2019

Description

Rendering classes in ITKVtkGlue do not work. Example failure:

Command Line
/home/dzenan/Dashboards/Tests/ITK-build/bin/ITKLevelSetsv4VisualizationTestDriver "itkVTKVisualize2DCellsLevelSetSurfaceTest" "/home/dzenan/Dashboards/Tests/ITK-build/ExternalData/Modules/Segmentation/LevelSetsv4Visualization/test/Input/cells.png" "60" "Dense" "/home/dzenan/Dashboards/Tests/ITK-build/Testing/Temporary/itkVTKVisualize2DCellsDenseLevelSetSurfaceTest.png"

Test output
Input image read
Finished converting to sparse format
Heaviside function created
LevelSetContainer created
Chan and Vese internal term created
Chan and Vese external term created
Term container created
Equation container created
Stopping criteria created
Generic Warning: In /home/dzenan/VTK-7.1.1/Rendering/Core/vtkRenderer.cxx, line 52
Error: no override found for 'vtkRenderer'.

Steps to Reproduce

  1. Turn on ITKVtkGlue and ITKLevelSetsv4Visualization modules
  2. Configure, build, run tests

Expected behavior

All tests pass

Actual behavior

20 or so tests fail:
https://open.cdash.org/viewTest.php?onlyfailed&buildid=5860842

Reproducibility

100%

Versions

All recent versions

Environment

Ubuntu 16.04 and Windows 10.

Additional Information

Related to #714 and #731 (comment).

@dzenanz dzenanz added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Apr 16, 2019
@thewtex
Copy link
Member

thewtex commented Apr 23, 2019

The discussion in #424 suggests that adding

vtk_module_autoinit(
  TARGETS ITKVtkGlueTestDriver
MODULES ${VTK_LIBRARIES})

to ITK/Modules/Bridge/VtkGlue/test/CMakeLists.txt should address the issue.

@thewtex thewtex added area:ThirdParty Issues affecting the ThirdParty module area:Bridge Issues affecting the Bridge module and removed area:Bridge Issues affecting the Bridge module labels Apr 23, 2019
@thewtex thewtex added this to the ITK v5.0.0 milestone Apr 24, 2019
@dzenanz
Copy link
Member Author

dzenanz commented Apr 30, 2019

Still does not work on Windows:

Dzenan@Ryzenator MINGW64 /c/Dev/ITK-2k17
$ /c/Dev/ITK-2k17/bin/RelWithDebInfo/ITKLevelSetsv4VisualizationTestDriver.exe "itkVTKVisualizeLevelSetsInteractivePauseTest" "C:/Dev/ITK-2k17/ExternalData/Modules/Segmentation/LevelSetsv4Visualization/test/Input/cells.png" "30"
Input image read
Segmentation fault

Screenshot 2019-04-29 19 28 51

@dzenanz dzenanz reopened this Apr 30, 2019
@dzenanz
Copy link
Member Author

dzenanz commented Apr 30, 2019

Or Linux:

Generic Warning: In /home/dzenan/VTK-7.1.1/Rendering/Core/vtkImageSliceMapper.cxx, line 35
Error: no override found for 'vtkImageSliceMapper'.

https://open.cdash.org/testDetails.php?test=670818924&build=5883445

@thewtex
Copy link
Member

thewtex commented May 7, 2019

@dzenanz does the vtk_module_autoinit code result improve the result?

@dzenanz dzenanz assigned sjh26 and dzenanz and unassigned sjh26 May 8, 2019
@dzenanz
Copy link
Member Author

dzenanz commented May 10, 2019

Sadly, that does not even configure:

CMake Error at Modules/Bridge/VtkGlue/test/CMakeLists.txt:23 (vtk_module_autoinit):
  Unknown CMake command "vtk_module_autoinit".

-- Configuring incomplete, errors occurred!

@mathstuf
Copy link
Contributor

Here's a commit which gets the Vis tests passing again: mathstuf@63e26fa. Needs some massaging to also support 8.2. See https://gitlab.kitware.com/vtk/vtk/issues/17604 for getting better autoinit support for header-only libraries (something I didn't think about before since header-only VTK usage wasn't something I had considered).

@dzenanz
Copy link
Member Author

dzenanz commented May 17, 2019

In order to avoid separately maintaining ITKLevelSetsv4Visualization, we decided to move it to a new remote module ITKVtkGlue, thus effectively merging it with ITKVtkGlue. The new module should become active/buildable after ITKv5.0.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants