Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump ITK and replace http with https using script #89

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented May 31, 2022

@tbirdso tbirdso requested a review from dzenanz May 31, 2022 15:51
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have non-trivial test failures.

@dzenanz dzenanz requested a review from aylward June 1, 2022 06:26
@tbirdso
Copy link
Contributor Author

tbirdso commented Jun 1, 2022

Pushed a change removing changes to binary PDF file, do not expect this will fix tests.

@tbirdso
Copy link
Contributor Author

tbirdso commented Jun 1, 2022

Seeing repeated failures of the following type:

itk::ExceptionObject (0x5648b69046d0)
Location: "unknown"
File: /home/runner/work/ITKMinimalPathExtraction/ITK/Modules/Filtering/FastMarching/include/itkFastMarchingUpwindGradientImageFilter.h
Line: 267
Description: ITK ERROR: FastMarchingUpwindGradientImageFilter(0x5648b6a62da0): No target point set. Cannot set the target reached mode.

@tbirdso
Copy link
Contributor Author

tbirdso commented Jun 1, 2022

Note that the failures also exist in #88.

@aylward
Copy link
Member

aylward commented Jul 6, 2022

Tests fixed in #90

Copy link
Member

@aylward aylward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylward aylward merged commit c4c585c into master Jul 6, 2022
aylward added a commit to InsightSoftwareConsortium/ITK that referenced this pull request Aug 8, 2022
* ENH: Bump MinimalPathExtraction module to v1.2.2

# Changes

* COMP: Remove inclusion of .hxx files as headers by @hjmjohnson in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#86
* COMP: Modules need updated version of ITK by @hjmjohnson in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#87
* BUG: Set FastMarching targets prior to reach mode by @aylward in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#90
* ENH: Bump ITK and replace http with https using script by @tbirdso in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#89
* ENH: Update Python package for itk-5.3rc4 by @thewtex in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#88
* ENH: Bump ITK to v5.3rc04(.post2) by @aylward in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#93

* @tbirdso made their first contribution in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#89

**Full Changelog**:
InsightSoftwareConsortium/ITKMinimalPathExtraction@v1.2.0...v1.2.1

* ENH: Bump MinimalPathExtraction to v1.2.2

v1.2.1 had a minor bug that would have prevented it from correctly
resolving future versions of ITK

See
https://github.com/InsightSoftwareConsortium/ITKMinimalPathExtraction/releases/tag/v1.2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants